build(pyproject): declare requires-python via PEP 621 [project] metadata#2213
Merged
hansthen merged 2 commits intopython-visualization:mainfrom Apr 23, 2026
Merged
Conversation
…etadata Add a minimal `[project]` table to `pyproject.toml` and set: - `requires-python = ">=3.9"` - `name = "folium"` - `dynamic = [...]` for fields still sourced from `setup.py` Why this is needed: `python_requires` in `setup.py` is not enough for tools that read interpreter constraints from `pyproject.toml` metadata. Per PEP 621, `requires-python` belongs in `[project]`, which allows `uv` to resolve/lock against the correct Python range instead of defaulting incorrectly (see astral-sh/uv#11424).
Collaborator
|
The pre-commit hooks are failing on the autoformatter. (Which is weird because I see no change in the corresponding files). This change is required for uv? It seems okay for now. |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a minimal
[project]table topyproject.tomland set:requires-python = ">=3.9"name = "folium"dynamic = [...]for fields still sourced fromsetup.pyWhy this is needed:
python_requiresinsetup.pyis not enough for tools that read interpreter constraints frompyproject.tomlmetadata. Per PEP 621,requires-pythonbelongs in[project], which allowsuvto resolve/lock against the correct Python range instead of defaulting incorrectly (see astral-sh/uv#11424).